What is the significance of Java rpg?
was looking for suggestions on how to improve the general flow of this code, as well as minimizing if / switch conditionals. Any suggestions are welcome however, as well as general game and game play suggestions (player scaling, enemy scaling, attack and enemy attack probabilities, which are handled in the dice class).
import java.util.*;
public class driver {
static Scanner scan = new Scanner(System.in);
static Random rand = new Random();
static dice die = new dice();
public static String playerName;
public static int playerhp;
public static int maxhp;
public static int maxmana;
public static int mana;
public static int playermeleedmg;
public static int xp;
public static int enemyhp;
public static int enemymeleedmg;
public static int Level;
public static String charclass;
public static boolean fighting = false; //globals for player stats & enemy stats
private static void printStats() {
if(charclass.equals("mage")){
System.out.println(playerName + "nhp: " + playerhp + "nmana: " + mana + "ndamage: " + playermeleedmg + "nxp: " + xp + "n");
}else{
System.out.println(playerName + "nhp: " + playerhp + "ndamage: " + playermeleedmg + "nxp: " + xp + "n");
}
}
private static void printEnemyStats() {
System.out.println("Enemy "+"nhp: " + enemyhp + "ndmg: " + enemymeleedmg + "n");
}
private static void buildWarrior() {
charclass = "warrior";
maxhp = 20;
playerhp = 20;
playermeleedmg = 4;
xp = 0;
Level = 1;
}
private static void buildArcher() {
charclass = "archer";
maxhp = 14;
playerhp = 14;
playermeleedmg = 6;
xp = 0;
Level = 1;
}
private static void buildMage() {
charclass = "mage";
maxhp = 10;
playerhp = 10;
mana = 20;
maxmana = 20;
playermeleedmg = 2;
xp = 0;
Level = 1; // initializes globals according to class
}
private static void buildEnemy() {
switch(Level){
case 1:
enemyhp = 9;
enemymeleedmg = 1;
break;
case 2:
enemyhp = 19;
enemymeleedmg = 4;
break;
case 3:
enemyhp = 24;
enemymeleedmg = 6;
break;
case 4:
enemyhp = 32;
enemymeleedmg = 7;
break;
case 5:
enemyhp = 40;
enemymeleedmg = 9;
break; //initializes enemy stats based on player level
}
}
private static void fight() {
String action;
String spellAction = null;
System.out.println("An enemy approaches");
buildEnemy();
fighting = true;
while(fighting = true){
System.out.println("Press 'a' to attacknPress 'i' for info");
if(charclass.equals("mage")){
System.out.print("Press 's' for spellsn");
}
action = scan.nextLine();
if(action.charAt(0) == 'a'){
fighting = attack();
if(fighting == false){
switch(Level){
case 1:
xp = xp + 4;
break;
case 2:
xp = xp + 6;
break;
case 3:
xp = xp + 9;
break;
case 4:
xp = xp + 12;
break;
}
System.out.println("You earned :" + xp + " xp");
checkLevelUp();
return;
}
enemyattack();
}
if(action.charAt(0) == 'i'){
printStats();
printEnemyStats();
}
if(action.charAt(0) == 's'){
System.out.println("Press 'f' for fireballnPress 'h' to healn");
spellAction = scan.nextLine();
if(spellAction.charAt(0) == 'f'){
if(die.roll10() > 2){
mana = mana - 10;
if(mana <0> System.out.println("You don't have enough mana...");
mana = mana + 10;
}else{
int k = die.roll10(); //randomly hurts 1-10
System.out.println("You hit for " + k + " damage!");
enemyhp = enemyhp - k;
if(enemyhp <= 0){
System.out.println("You Won!");
switch(Level){
case 1:
xp = xp + 4;
break;
case 2:
xp = xp + 6;
break;
case 3:
xp = xp + 9;
break;
case 4:
xp = xp + 12;
break;
}
System.out.println("You earned :" + xp + " xp");
checkLevelUp();
return;
}
enemyattack();
}
}
else{
System.out.println("You miss!");
enemyattack();
}
}else
if(spellAction.charAt(0) == 'h'){
mana = mana - 8;
if(mana <0> System.out.println("You don't have enough mana...");
mana = mana + 8;
}else{
int x = die.roll10(); //randomly heals 1-8
System.out.println("You heal your wounds...");
System.out.println("+ " + x + " hp");
playerhp = playerhp + x;
if(playerhp>maxhp){
playerhp = maxhp;
}
enemyattack();
}
}
}
}
}
private static void checkLevelUp() {
if(xp >= 100 && Level == 4){
System.out.println("Level 5!");
Level = Level + 1;
maxhp = maxhp + 25;
playerhp = maxhp;
if(charclass.equals("mage")){
maxmana = maxmana + 7;
mana = maxmana;
}
playermeleedmg = playermeleedmg + 3;
printStats();
}else
if(xp >= 50 && Level == 3){
System.out.println("Level 4!");
Level = Level + 1;
maxhp = maxhp + 20;
playerhp = maxhp;
if(charclass.equals("mage")){
maxmana = maxmana + 7;
mana = maxmana;
}
playermeleedmg = playermeleedmg + 2;
printStats();
}else
if(xp >= 25 && Level == 2){
System.out.println("Level 3!");
Level = Level + 1;
maxhp = maxhp + 10;
playerhp = maxhp;
if(charclass.equals("mage")){
maxmana = maxmana + 7;
mana = maxmana;
}
playermeleedmg = playermeleedmg + 2;
printStats();
}else
if(xp >= 10 && Level == 1){
System.out.println("Level 2!");
Level = Level + 1;
maxhp = maxhp + 5;
playerhp = maxhp;
if(charclass.equals("mage")){
maxmana = maxmana + 7;
mana = maxmana;
}
playermeleedmg = playermeleedmg + 1;
printStats();
}//increments player level and adds to stats with xp
}
private static void enemyattack() {
if(die.roll6() > 2){
System.out.println("Enemy hits!");
playerhp = playerhp - enemymeleedmg;
if(playerhp <= 0){
gameover();
System.exit(0);//game over if player health < 0> }
}else{
System.out.println("Enemy Misses!");
}
}
private static boolean attack() {
if(die.roll6() > 2){
System.out.println("You hit!");
enemyhp = enemyhp - playermeleedmg;
if(enemyhp <= 0){
System.out.println("You Won!"); //prints if enemy health < 0> return false;
}
}else{
System.out.println("You miss!");
}
return true;
}
private static void gameover() {
System.out.println(playerName + " Died!") ;
System.out.println("GAME OVER!");
System.exit(0); //terminates if lost
return;
}
public static void main(String[] args) {
String charclass;
int num = 2;
while(num > 1){
System.out.println("Enter your Name: ");
playerName = scan.nextLine();
System.out.println("Choose your class: ");
System.out.println("'w' for warrior");
System.out.println("'a' for archer");
System.out.println("'m' for mage");
charclass = scan.nextLine();
while(charclass.charAt(0) != 'w' && charclass.charAt(0) != 'a' && charclass.charAt(0) != 'm'){
System.out.println("'w' for warrior");
System.out.println("'a' for archer");
System.out.println("'m' for mage");
charclass = scan.nextLine();
}
if(charclass.charAt(0) == 'w'){
buildWarrior();
}
if(charclass.charAt(0) == 'a'){
buildArcher();
}
if(charclass.charAt(0) == 'm'){
buildMage();
}
printStats();
while(Level == 1){
fight();
}
System.out.println("This area is clear... time to move onn");
while(Level == 2){
fight();
}
System.out.println("This area is clear... time to move onn");
while(Level == 3){
fight();
}
System.out.println("This area is clear... time to move onn");
while(Level == 4){
fight();
}
System.out.println("This area is clear... time to move onn");
while(Level == 5){
fight();
}//keeps in area until levelUp
}
}
}
import java.util.*;
public class dice {
public int roll6(){
Random rand = new Random();
int n = rand.nextInt(7);
while(n == 0){
n = rand.nextInt(7);
}//1-6
return n;
}
public int roll10(){
Random rand = new Random();
int n = rand.nextInt(11);
while(n == 0){
n = rand.nextInt(11);
}
return n;
}//1-10
public int roll20(){
Random rand = new Random();
int n = rand.nextInt(21);
while(n == 0){
n = rand.nextInt(21);
}//1-20
return n;
}
}
java
beginner
console
dice
role-playing-game
Regarding the Java RPG -
OOP
This task really begs for object oriented programming.
As a first step,
I suggest moving the maxhp, playerhp, playermeleedmg, xp, level fields to a dedicated class for players, and rewrite the build* methods. You could create a PlayerFactory with the build* methods that create and return warriors, archers, mages, enemies. All these different kinds of characters could inherit from a common base Player class.
Rolling the dice
To get a random number x in the inclusive range of [1:6], instead of rand.nextInt(7) and skipping zeros in a while loop, you should use 1 + rand.nextInt(6) to get the same effect.
The roll6, roll10, roll20 methods all use the same logic. Just one roll method with a parameter could do the job:
public class dice {
private final Random random = new Random();
public int roll(int max) {
return 1 + random.nextInt(max);
}
public int roll6() {
return roll(6);
}
// and so on ...
}As demonstrated in this example, you probably don't need a new Random instance before each roll.
Chaining conditions
These conditions are mutually exclusive, therefore they should be chained with else if rather than using multiple independent if statements:
if(charclass.charAt(0) == 'w'){
buildWarrior();
}
if(charclass.charAt(0) == 'a'){
buildArcher();
}
if(charclass.charAt(0) == 'm'){
buildMage();
}In this example a switch would be even better, so that charclass.charAt(0) will only be evaluated once.
Don't repeat yourself
There are near-duplicate lines at multiple places. For example the enemyattack and attack methods implement the same logic, with only minor differences in the details. Those details can be parameters, so that you can avoid copy-pasting code. Later when you need to update copy-pasted sections, it will be extremely annoying to make parallel changes at multiple locations, and it will be very error-prone too. Probably 99% of the time it's better to extract common logic and generalise than to copy-paste.
Formatting
You're using Eclipse Luna, it has a feature to reformat nicely the entire code. It's good to use that until it becomes a natural habit to type nicely.